我最近一直在用c#和Java编程，我很好奇初始化我的类字段的最佳位置在哪里。
我应该在申报时申报吗?：
public class Dice
{
private int topFace = 1;
private Random myRand = new Random();
public void Roll()
{
// ......
}
}
或者在构造函数中?：
public class Dice
{
private int topFace;
private Random myRand;
public Dice()
{
topFace = 1;
myRand = new Random();
}
public void Roll()
{
// .....
}
}
我很好奇你们这些老兵认为最好的做法是什么。我想保持一致，坚持一种方法。
当前回答
Consider the situation where you have more than one constructor. Will the initialization be different for the different constructors? If they will be the same, then why repeat for each constructor? This is in line with kokos statement, but may not be related to parameters. Let's say, for example, you want to keep a flag which shows how the object was created. Then that flag would be initialized differently for different constructors regardless of the constructor parameters. On the other hand, if you repeat the same initialization for each constructor you leave the possibility that you (unintentionally) change the initialization parameter in some of the constructors but not in others. So, the basic concept here is that common code should have a common location and not be potentially repeated in different locations. So I would say always put it in the declaration until you have a specific situation where that no longer works for you.
其他回答
在声明中设置值会略微提高性能。如果你在构造函数中设置它，它实际上被设置了两次(第一次为默认值，然后在ctor中重置)。
“更喜欢在声明中初始化”，似乎是一个很好的一般实践。
这里是一个不能在声明中初始化的例子，所以它必须在构造函数中完成。 错误CS0236字段初始化器不能引用非静态字段、方法或属性
class UserViewModel
{
// Cannot be set here
public ICommand UpdateCommad { get; private set; }
public UserViewModel()
{
UpdateCommad = new GenericCommand(Update_Method); // <== THIS WORKS
}
void Update_Method(object? parameter)
{
}
}
我通常尝试构造函数不做任何事情，只是获取依赖项并初始化相关的实例成员。如果您想对类进行单元测试，这将使您的工作更加轻松。
如果要分配给实例变量的值不受要传递给构造函数的任何参数的影响，则在声明时分配它。
如果我告诉你，这要看情况?
我通常初始化所有东西，并以一致的方式进行。是的，它过于明确，但它也更容易维护。
如果我们担心性能，那么我只初始化必须要做的事情，并将其放在性价比最高的地方。
在实时系统中，我甚至怀疑我是否需要变量或常数。
在c++中，我经常在这两个地方都不初始化，而是将它移动到Init()函数中。为什么?好吧，在c++中，如果你初始化的东西可能会在对象构造过程中抛出异常，你就会导致内存泄漏。
In Java, an initializer with the declaration means the field is always initialized the same way, regardless of which constructor is used (if you have more than one) or the parameters of your constructors (if they have arguments), although a constructor might subsequently change the value (if it is not final). So using an initializer with a declaration suggests to a reader that the initialized value is the value that the field has in all cases, regardless of which constructor is used and regardless of the parameters passed to any constructor. Therefore use an initializer with the declaration only if, and always if, the value for all constructed objects is the same.
